FindBugs Bug Detector Report
The following document contains the results of FindBugs
FindBugs Version is 3.0.1
Threshold is low
Effort is max
Summary
| Classes |
Bugs |
Errors |
Missing Classes |
| 592 |
34 |
0 |
0 |
com.github.aptd.simulation.common.CConfiguration
| Bug |
Category |
Details |
Line |
Priority |
| Exceptional return value of java.io.File.mkdirs() ignored in com.github.aptd.simulation.common.CConfiguration.createdefault() |
BAD_PRACTICE |
RV_RETURN_VALUE_IGNORED_BAD_PRACTICE |
152 |
Medium |
com.github.aptd.simulation.core.experiment.local.CExperiment$CMessageSendAction
| Bug |
Category |
Details |
Line |
Priority |
| com.github.aptd.simulation.core.experiment.local.CExperiment$CMessageSendAction is serializable but also an inner class of a non-serializable class |
BAD_PRACTICE |
SE_BAD_FIELD_INNER_CLASS |
197 |
Low |
com.github.aptd.simulation.core.messaging.local.CMessage
| Bug |
Category |
Details |
Line |
Priority |
| com.github.aptd.simulation.core.messaging.local.CMessage.content() may expose internal representation by returning CMessage.m_content |
MALICIOUS_CODE |
EI_EXPOSE_REP |
90 |
Medium |
com.github.aptd.simulation.core.messaging.local.CMessenger
| Bug |
Category |
Details |
Line |
Priority |
| CMessenger.m_experiment not initialized in constructor and dereferenced in com.github.aptd.simulation.core.messaging.local.CMessenger.lambda$call$1(IMessage) |
STYLE |
UWF_FIELD_NOT_INITIALIZED_IN_CONSTRUCTOR |
59 |
Low |
com.github.aptd.simulation.core.statistic.local.CStatistic$CStatisticAction
| Bug |
Category |
Details |
Line |
Priority |
| Use of non-localized String.toUpperCase() or String.toLowerCase() in com.github.aptd.simulation.core.statistic.local.CStatistic$CStatisticAction.execute(boolean, IContext, List, List) |
I18N |
DM_CONVERT_CASE |
145 |
Low |
| com.github.aptd.simulation.core.statistic.local.CStatistic$CStatisticAction is serializable but also an inner class of a non-serializable class |
BAD_PRACTICE |
SE_BAD_FIELD_INNER_CLASS |
114 |
Low |
com.github.aptd.simulation.core.writer.local.CYaml
| Bug |
Category |
Details |
Line |
Priority |
| Found reliance on default encoding in com.github.aptd.simulation.core.writer.local.CYaml.apply(): new java.io.FileWriter(String) |
I18N |
DM_DEFAULT_ENCODING |
79 |
High |
| com.github.aptd.simulation.core.writer.local.CYaml.apply() may fail to clean up java.io.Writer |
EXPERIMENTAL |
OBL_UNSATISFIED_OBLIGATION |
79 |
Medium |
com.github.aptd.simulation.datamodel.CXMLReader
| Bug |
Category |
Details |
Line |
Priority |
| Exception is caught when Exception is not thrown in com.github.aptd.simulation.datamodel.CXMLReader.get(IFactory, String, long, boolean, String, Supplier) |
STYLE |
REC_CATCH_EXCEPTION |
199 |
Medium |
| Exception is caught when Exception is not thrown in com.github.aptd.simulation.datamodel.CXMLReader.get(IFactory, String, long, boolean, String, Supplier) |
STYLE |
REC_CATCH_EXCEPTION |
135 |
Low |
com.github.aptd.simulation.elements.IBaseElement
| Bug |
Category |
Details |
Line |
Priority |
| Private method com.github.aptd.simulation.elements.IBaseElement.currentTime() is never called |
PERFORMANCE |
UPM_UNCALLED_PRIVATE_METHOD |
264 |
Low |
| Private method com.github.aptd.simulation.elements.IBaseElement.getNextActivation() is never called |
PERFORMANCE |
UPM_UNCALLED_PRIVATE_METHOD |
278 |
Low |
| Private method com.github.aptd.simulation.elements.IBaseElement.maxTime() is never called |
PERFORMANCE |
UPM_UNCALLED_PRIVATE_METHOD |
271 |
Low |
| Private method com.github.aptd.simulation.elements.IBaseElement.setNextActivation(ZonedDateTime) is never called |
PERFORMANCE |
UPM_UNCALLED_PRIVATE_METHOD |
285 |
Low |
com.github.aptd.simulation.elements.IStatefulElement
| Bug |
Category |
Details |
Line |
Priority |
| Inconsistent synchronization of com.github.aptd.simulation.elements.IStatefulElement.m_nextstatechange; locked 66% of time |
MT_CORRECTNESS |
IS2_INCONSISTENT_SYNC |
104 |
Medium |
com.github.aptd.simulation.elements.grid.local.CJPSPlusStatic$CCompareJumpPoint
| Bug |
Category |
Details |
Line |
Priority |
| com.github.aptd.simulation.elements.grid.local.CJPSPlusStatic$CCompareJumpPoint implements Comparator but not Serializable |
BAD_PRACTICE |
SE_COMPARATOR_SHOULD_BE_SERIALIZABLE |
338 |
Medium |
com.github.aptd.simulation.elements.passenger.CPassenger
| Bug |
Category |
Details |
Line |
Priority |
| Class com.github.aptd.simulation.elements.passenger.CPassenger defines non-transient non-serializable instance field m_itinerary |
BAD_PRACTICE |
SE_BAD_FIELD |
|
Medium |
com.github.aptd.simulation.elements.passenger.CPassenger$CItineraryEntry
| Bug |
Category |
Details |
Line |
Priority |
| Unread field: com.github.aptd.simulation.elements.passenger.CPassenger$CItineraryEntry.m_arrivaltime |
PERFORMANCE |
URF_UNREAD_FIELD |
425 |
Low |
| Unread field: com.github.aptd.simulation.elements.passenger.CPassenger$CItineraryEntry.m_arrivaltrack |
PERFORMANCE |
URF_UNREAD_FIELD |
427 |
Low |
| Unread field: com.github.aptd.simulation.elements.passenger.CPassenger$CItineraryEntry.m_departurestation |
PERFORMANCE |
URF_UNREAD_FIELD |
422 |
Low |
| Unread field: com.github.aptd.simulation.elements.passenger.CPassenger$CItineraryEntry.m_departuretime |
PERFORMANCE |
URF_UNREAD_FIELD |
424 |
Low |
com.github.aptd.simulation.elements.passenger.CPassengerSource
| Bug |
Category |
Details |
Line |
Priority |
| Inconsistent synchronization of com.github.aptd.simulation.elements.passenger.CPassengerSource.m_passengersgenerated; locked 83% of time |
MT_CORRECTNESS |
IS2_INCONSISTENT_SYNC |
150 |
Low |
| Class com.github.aptd.simulation.elements.passenger.CPassengerSource defines non-transient non-serializable instance field m_experiment |
BAD_PRACTICE |
SE_BAD_FIELD |
|
Medium |
| Class com.github.aptd.simulation.elements.passenger.CPassengerSource defines non-transient non-serializable instance field m_generator |
BAD_PRACTICE |
SE_BAD_FIELD |
|
Medium |
com.github.aptd.simulation.elements.passenger.CPassengerSource$CGenerator
| Bug |
Category |
Details |
Line |
Priority |
| Use of non-localized String.toUpperCase() or String.toLowerCase() in com.github.aptd.simulation.elements.passenger.CPassengerSource$CGenerator.generate(Object[]) |
I18N |
DM_CONVERT_CASE |
202 |
Low |
com.github.aptd.simulation.elements.train.CDoor
| Bug |
Category |
Details |
Line |
Priority |
| com.github.aptd.simulation.elements.train.CDoor.lockifrequested(List) uses the same code for two switch clauses |
STYLE |
DB_DUPLICATE_SWITCH_CLAUSES |
291 |
Low |
| Return value of java.util.Queue.poll() ignored in com.github.aptd.simulation.elements.train.CDoor.passengerfinished(IMessage) |
CORRECTNESS |
RV_RETURN_VALUE_IGNORED |
359 |
Low |
com.github.aptd.simulation.elements.train.CTrain
| Bug |
Category |
Details |
Line |
Priority |
| Inconsistent synchronization of com.github.aptd.simulation.elements.train.CTrain.m_positionontrack; locked 80% of time |
MT_CORRECTNESS |
IS2_INCONSISTENT_SYNC |
266 |
Medium |
| Inconsistent synchronization of com.github.aptd.simulation.elements.train.CTrain.m_state; locked 88% of time |
MT_CORRECTNESS |
IS2_INCONSISTENT_SYNC |
264 |
Medium |
| Inconsistent synchronization of com.github.aptd.simulation.elements.train.CTrain.m_ttindex; locked 66% of time |
MT_CORRECTNESS |
IS2_INCONSISTENT_SYNC |
225 |
Medium |
| Class com.github.aptd.simulation.elements.train.CTrain defines non-transient non-serializable instance field m_position |
BAD_PRACTICE |
SE_BAD_FIELD |
|
Medium |
| Class com.github.aptd.simulation.elements.train.CTrain defines non-transient non-serializable instance field m_timetable |
BAD_PRACTICE |
SE_BAD_FIELD |
|
Medium |
| Uninitialized read of m_ttindex in new com.github.aptd.simulation.elements.train.CTrain(IAgentConfiguration, String, Stream, List, Stream, ITime) |
CORRECTNESS |
UR_UNINIT_READ |
118 |
Medium |
com.github.aptd.simulation.factory.EFactory
| Bug |
Category |
Details |
Line |
Priority |
| Use of non-localized String.toUpperCase() or String.toLowerCase() in com.github.aptd.simulation.factory.EFactory.from(String) |
I18N |
DM_CONVERT_CASE |
68 |
Low |
